svn commit: r273919 - head/etc/rc.d

[Garrett Cooper]

On Oct 31, 2014, at 17:51, Dag-Erling Smørgrav <des at des.no> wrote:

> Xin LI <delphij at FreeBSD.org> writes:
>> Log:
>>  rc.d/geli should not depend on random, as the attach functionality
>>  do not require additional entropy to function.
>> 
>>  It would create a circular dependency (not immediately obvious:
>>  geli provides 'disks' and requires 'random' as of r273872,
>>  'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root',
>>  'root' requires 'swap', and finally 'swap' requires 'disk').
> 
> My first instinct was: shouldn't rcorder warn about this?  It turns out
> that it does, but in a very cryptic fashion:
> 
> des at nine ~head/etc/rc.d% svn up -qr273871  
> des at nine ~head/etc/rc.d% rcorder * >/dev/null
> des at nine ~head/etc/rc.d% svn up -qr273872    
> des at nine ~head/etc/rc.d% rcorder * >/dev/null
> rcorder: Circular dependency on file `zfs'.
> rcorder: Circular dependency on provision `mountcritlocal' in file `zfs'.
> rcorder: Circular dependency on provision `mountcritlocal' in file `var'.
> rcorder: Circular dependency on provision `mountcritlocal' in file `FILESYSTEMS'.
> rcorder: Circular dependency on provision `root' in file `FILESYSTEMS'.
> des at nine ~head/etc/rc.d% svn up -qr273919    
> des at nine ~head/etc/rc.d% rcorder * >/dev/null
> des at nine ~head/etc/rc.d% 

rcorder errors are indeed cryptic/confusing. I can quickly add a testcase for this if you like (basically check for all the scenarios that need to be covered via /etc/rc). Does that sound good?
Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20141031/03fd0b31/attachment.sig>