svn commit: r266278 - head/share/mk

[Warner Losh]

On May 17, 2014, at 10:57 AM, Dimitry Andric <dim at freebsd.org> wrote:

> On 17 May 2014, at 16:27, Warner Losh <imp at bsdimp.com> wrote:
>> 
>> On May 17, 2014, at 9:56 AM, Dimitry Andric <dim at FreeBSD.org> wrote:
>> 
>>> On 17 May 2014, at 03:47, Warner Losh <imp at FreeBSD.org> wrote:
>>>> Author: imp
>>>> Date: Sat May 17 01:47:06 2014
>>>> New Revision: 266278
>>>> URL: http://svnweb.freebsd.org/changeset/base/266278
>>>> 
>>>> Log:
>>>> Read in SRCCONF early and consistently, if src.sys.mk exists, which is
>>>> should for all normal builds. Read /etc/make.conf earlier than before,
>>>> but consistently before SRCCONF and local.sys.mk.
>>> 
>>> I'm not yet sure why, but this breaks buildworld badly.  During bootstrap-tools, you immediately get:
>> 
>> Haven’t seen this in my testing. Please send me your /etc/make.conf and /etc/src.conf. Or tell me your environment. Would love to fix it...
> 
> Try an empty make.conf (or __MAKE_CONF=/dev/null), and just this line in src.conf:
> 
> CXXFLAGS+= -std=c++11
> 
> That breaks it.

We define CXXFLAGS later rather than sooner now.

CXXFLAGS        ?=      ${CFLAGS:N-std=*:N-Wnested-externs:N-W*-prototypes:N-Wno-pointer-sign:N-Wold-style-definition}

would have been executed, but the change caused that to not happen (since you effectively set CXXFLAGS to -std=c++11).

I’m not sure what I think of this breakage, but I’ll look into correcting it. I’m not really sure what the proper fix is though…

Warner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20140517/770b68c7/attachment.sig>