svn commit: r269020 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Wed Jul 23 18:04:52 2014
New Revision: 269020
URL: http://svnweb.freebsd.org/changeset/base/269020

Log:
  Cosmetic changes to unp_internalize
  
  Don't throw away the result of fget_unlocked.
  Move fdp increment to for loop to make it consistent with similar code
  elsewhere.
  
  MFC after:	1 week

Modified:
  head/sys/kern/uipc_usrreq.c

Modified: head/sys/kern/uipc_usrreq.c
==============================================================================
--- head/sys/kern/uipc_usrreq.c	Wed Jul 23 16:18:54 2014	(r269019)
+++ head/sys/kern/uipc_usrreq.c	Wed Jul 23 18:04:52 2014	(r269020)
@@ -1853,7 +1853,7 @@ unp_internalize(struct mbuf **controlp, 
 	struct filedescent *fde, **fdep, *fdev;
 	struct file *fp;
 	struct timeval *tv;
-	int i, fd, *fdp;
+	int i, *fdp;
 	void *data;
 	socklen_t clen = control->m_len, datalen;
 	int error, oldfds;
@@ -1906,14 +1906,13 @@ unp_internalize(struct mbuf **controlp, 
 			 */
 			fdp = data;
 			FILEDESC_SLOCK(fdesc);
-			for (i = 0; i < oldfds; i++) {
-				fd = *fdp++;
-				if (fget_locked(fdesc, fd) == NULL) {
+			for (i = 0; i < oldfds; i++, fdp++) {
+				fp = fget_locked(fdesc, *fdp);
+				if (fp == NULL) {
 					FILEDESC_SUNLOCK(fdesc);
 					error = EBADF;
 					goto out;
 				}
-				fp = fdesc->fd_ofiles[fd].fde_file;
 				if (!(fp->f_ops->fo_flags & DFLAG_PASSABLE)) {
 					FILEDESC_SUNLOCK(fdesc);
 					error = EOPNOTSUPP;