svn commit: r262351 - head/sys/netinet6

[Andrey V. Elsukov]

On 24.02.2014 12:34, Craig Rodrigues wrote:
> 
> On Feb 23, 2014 2:56 PM, "Bjoern A. Zeeb" <bz at freebsd.org
> <mailto:bz at freebsd.org>> wrote:
>>
>>
>> On 23 Feb 2014, at 01:27 , Craig Rodrigues <rodrigc at FreeBSD.org> wrote:
>>
>> > Author: rodrigc
>> > Date: Sun Feb 23 01:27:22 2014
>> > New Revision: 262351
>> > URL: http://svnweb.freebsd.org/changeset/base/262351
>> >
>> > Log:
>> >  Remove KASSERT from in6p_lookup_mcast_ifp().
>> >
>> >  When the devel/jenkins port, version 1.551 was started,
>> >  the kernel would panic if INVARIANTS was enabled in the kernel config.
>> >
>> >  Suggested by: bms
>>
>> This reads to me “we hit the assert, bms suggested to remove it”.
>  Great!  Caught a bug!  Where is it?  In no way the commit message tells
> me why?   Why did we not hit the assert in the last n years? What has
> changed that we hit it now? Was the assert wrong from the beginning?
>  Did we hit a real bug elsewhere and now lost the tracking for it?
>>
>> Could you please at least for the archives explain?
> 
> Bruce suggested that I remove the KASSERT here:
> 
> http://lists.freebsd.org/pipermail/freebsd-net/2013-October/036806.html

There was my analysis:
http://lists.freebsd.org/pipermail/freebsd-net/2013-August/036545.html

I think it is safe to remove this KASSERT.

-- 
WBR, Andrey V. Elsukov