svn commit: r261604 - head/contrib/libc++/include
Alan Somers
asomers at freebsd.org
Fri Feb 7 18:14:20 UTC 2014
On Fri, Feb 7, 2014 at 11:10 AM, Eitan Adler <eadler at freebsd.org> wrote:
> Author: eadler
> Date: Fri Feb 7 18:10:34 2014
> New Revision: 261604
> URL: http://svnweb.freebsd.org/changeset/base/261604
>
> Log:
> HEAD is not buildable for the past day. Commit a 'quick fix' in order to permit
> buildworld to complete.
>
> Reviewed by: theraven
>
> Modified:
> head/contrib/libc++/include/locale
Are you sure that this will work on all architectures? It implicitly
assumes that ptrdiff_t is the same as long. IMHO, it's better to cast
the left side of the comparison to size_t, because it will always be
nonnegative as long as __a_end is greater than or equal to __a. They
certainly sound like it, based on the names.
-Alan
More information about the svn-src-head
mailing list