svn commit: r275923 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Xin LI delphij at FreeBSD.org
Fri Dec 19 00:20:30 UTC 2014


Author: delphij
Date: Fri Dec 19 00:20:29 2014
New Revision: 275923
URL: https://svnweb.freebsd.org/changeset/base/275923

Log:
  Add missing continue: we can't proceed further if the
  kernel does not panic with zfs_panic_recover.
  
  Illumos issue:
      5438 zfs_blkptr_verify should continue after zfs_panic_recover
  
  Reported by:	Coverity
  CID:		1232014

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c	Thu Dec 18 23:45:26 2014	(r275922)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c	Fri Dec 19 00:20:29 2014	(r275923)
@@ -704,18 +704,20 @@ zfs_blkptr_verify(spa_t *spa, const blkp
 			zfs_panic_recover("blkptr at %p DVA %u has invalid "
 			    "VDEV %llu",
 			    bp, i, (longlong_t)vdevid);
+			continue;
 		}
 		vdev_t *vd = spa->spa_root_vdev->vdev_child[vdevid];
 		if (vd == NULL) {
 			zfs_panic_recover("blkptr at %p DVA %u has invalid "
 			    "VDEV %llu",
 			    bp, i, (longlong_t)vdevid);
+			continue;
 		}
 		if (vd->vdev_ops == &vdev_hole_ops) {
 			zfs_panic_recover("blkptr at %p DVA %u has hole "
 			    "VDEV %llu",
 			    bp, i, (longlong_t)vdevid);
-
+			continue;
 		}
 		if (vd->vdev_ops == &vdev_missing_ops) {
 			/*


More information about the svn-src-head mailing list