svn commit: r275819 - in head/lib/msun: ld128 ld80 src

[Adrian Chadd]

On 18 December 2014 at 13:44, Warner Losh <wlosh at netflix.com> wrote:
>
>> On Dec 17, 2014, at 2:16 PM, Steve Kargl <sgk at troutmask.apl.washington.edu> wrote:
>>
>>
>> Ed's diff is ~1000 lines and touches several files.  Localizing
>> the change to math_private.h would have been a ~20 line
>> diff to a single file.
>
> Then just back his change out, put yours in and we all win. This seems like
> ample “this is better” justification to me. While there is a little more churn, external
> trackers will apply then unapply the churn, resulting in a net win. Especially if you
> do the blackout as one commit and the better fix as another, which means external
> trackers can just skip the two commits of churn with little effort on their part.

+1

And although the initial source stuff was a bit of a debate, I'm glad
that it led to a much cleaner looking long term solution.



-adrian