svn commit: r257945 - head/usr.sbin/pkg

Gleb Smirnoff glebius at FreeBSD.org
Mon Nov 11 19:38:22 UTC 2013


On Mon, Nov 11, 2013 at 02:19:38PM -0500, Eitan Adler wrote:
E> On Mon, Nov 11, 2013 at 10:35 AM, Bryan Drewery <bryan at shatow.net> wrote:
E> > On Mon, Nov 11, 2013 at 07:44:10AM +0000, Gleb Smirnoff wrote:
E> >> Author: glebius
E> >> Date: Mon Nov 11 07:44:09 2013
E> >> New Revision: 257945
E> >> URL: http://svnweb.freebsd.org/changeset/base/257945
E> >>
E> >> Log:
E> >>   Do not use just freed memory.
E> >>
E> >>   Sponsored by:       Nginx, Inc.
E> >
E> > Can you please also MFC this?
E> >
E> >>               if (fingerprint->name)
E> >>                       free(fingerprint->name);
E> 
E> While here, can you remove the if conditional by the free?

I'll do the MFC, but this styling issue I'd leave to pkg developers.

-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list