svn commit: r257691 - head/gnu/lib/libgcc

[Luigi Rizzo]

On Tue, Nov 05, 2013 at 07:37:35AM +0000, Dimitry Andric wrote:
> Author: dim
> Date: Tue Nov  5 07:37:35 2013
> New Revision: 257691
> URL: http://svnweb.freebsd.org/changeset/base/257691
> 
> Log:
>   Fix libgcc build with gcc after r257645, by using -Wno-static-in-inline
>   for clang only.

thanks.

I wonder if it is worthwhile adding to the default rules some
compiler-specific CFLAGS, say CFLAGS_CLANG and CFLAGS_GCC

(there is only a handful of cases now so maybe it is overkill,
and it harms readability; on the other hand, the Makefiles
already make a lot of assumptions on variable names)

% find ../head -name Makefile -exec grep -H COMPILER_TYPE \{\} \;
../head/gnu/lib/libgcc/Makefile:.if ${COMPILER_TYPE} != "clang" || ${TARGET_CPUARCH} != "arm"
../head/gnu/lib/libgcc/Makefile:.if ${COMPILER_TYPE} == "clang"
../head/gnu/lib/libsupc++/Makefile:.if ${COMPILER_TYPE} == "clang"
../head/gnu/lib/libstdc++/Makefile:.if ${COMPILER_TYPE} == "clang"
../head/tools/tools/ath/athstats/Makefile:.if (${COMPILER_TYPE} == "clang")
../head/tools/tools/net80211/wlanstats/Makefile:.if ${COMPILER_TYPE} == "clang"

	cheers
	luigi

> Modified:
>   head/gnu/lib/libgcc/Makefile
> 
> Modified: head/gnu/lib/libgcc/Makefile
> ==============================================================================
> --- head/gnu/lib/libgcc/Makefile	Tue Nov  5 07:36:17 2013	(r257690)
> +++ head/gnu/lib/libgcc/Makefile	Tue Nov  5 07:37:35 2013	(r257691)
> @@ -36,7 +36,9 @@ CFLAGS+=	-DIN_GCC -DIN_LIBGCC2 -D__GCC_F
>  #               function with external linkage [-Wstatic-in-inline]
>  # gcc_assert (index < (int) sizeof(dwarf_reg_size_table));
>  #                                  ^
> +.if ${COMPILER_TYPE} == "clang"
>  CFLAGS+=	-Wno-static-in-inline
> +.endif
>  
>  LDFLAGS+=	-nodefaultlibs
>  LDADD+=		-lc