this breaks builds of head on stable/9 (Re: svn commit: r257268 - head/gnu/usr.bin/binutils/ld

[Luigi Rizzo]

On Thu, Oct 31, 2013 at 09:09:24PM -0500, Brooks Davis wrote:
> On Thu, Oct 31, 2013 at 06:02:25PM -0700, Luigi Rizzo wrote:
> > as per the subject, after this commit building head on stable/9
> > fails with the error below:
> > 
> > ===> lib/libpam/modules/pam_krb5 (all)
> > make: don't know how to make
> > /media/bsd10/usr/home/luigi/FreeBSD/head/../usr/obj-pico-amd64/media/bsd10/usr/home/luigi/FreeBSD/head/tmp/usr/lib/libkrb5.a.
> > Stop
> > 
> > reverting the commit fixes the build.
> > 
> > Any idea how this can be fixed ?
> 
> I just built world and kernel with a freshly checked out head on
> ref9-amd64 so I supect something in your environment.  This change
> should only impact the installed copy of ld which would have no effect
> on a 9-stable system.  Any portion of the build system using a version
> effected by this change is broken since only the cross build version
> should be used and that one will have it's own sysroot value as always
> it always has.

ok so what happens is the following (trying to build HEAD on 9.2, both amd64)

- WITHOUT_CLANG and related options:
    "make toolchain"	fails with the error on krb5
    "make buildworld"	works, and a subsequent
				"make toolchain" also works

- without options (so compiling CLANG)

    "make toolchain"	fails with the error below

    building shared library libc.so.7
    /usr/bin/ld: this linker was not configured to use sysroots
    cc: error: linker command failed with exit code 1 (use -v to see invocation)
    *** [libc.so.7] Error code 1
    1 error
    *** [all] Error code 2
    1 error


"make toolchain" on an empty tree used to work until before this commit,
and does work if i revert this single change

So does this mean that 'toolchain' now has some prerequisites ?

    cheers
    luigi