svn commit: r253841 - head/sys/netinet6

[Alexander V. Chernikov]

On 01.08.2013 20:18, Rui Paulo wrote:
> On 1 Aug 2013, at 07:23, Gleb Smirnoff <glebius at FreeBSD.org> wrote:
>
>> On Wed, Jul 31, 2013 at 04:24:50PM +0000, Hiroki Sato wrote:
>> H> Author: hrs
>> H> Date: Wed Jul 31 16:24:49 2013
>> H> New Revision: 253841
>> H> URL: http://svnweb.freebsd.org/changeset/base/253841
>> H>
>> H> Log:
>> H>   Allocate in6_ifextra (ifp->if_afdata[AF_INET6]) only for IPv6-capable
>> H>   interfaces.  This eliminates unnecessary IPv6 processing for non-IPv6
>> H>   interfaces.
>> H>
>> H>   MFC after:	3 days
>> H>
>> H> Modified:
>> H>   head/sys/netinet6/in6.c
>> H>   head/sys/netinet6/in6_ifattach.c
>> H>   head/sys/netinet6/nd6.c
>> H>
>> H> Modified: head/sys/netinet6/in6.c
>> H> ==============================================================================
>> H> --- head/sys/netinet6/in6.c	Wed Jul 31 15:55:01 2013	(r253840)
>> H> +++ head/sys/netinet6/in6.c	Wed Jul 31 16:24:49 2013	(r253841)
>> H> @@ -2746,6 +2746,13 @@ in6_domifattach(struct ifnet *ifp)
>> H>  {
>> H>  	struct in6_ifextra *ext;
>> H>
>> H> +	/* There are not IPv6-capable interfaces. */
>> H> +	switch (ifp->if_type) {
>> H> +	case IFT_PFLOG:
>> H> +	case IFT_PFSYNC:
>> H> +	case IFT_USB:
>> H> +		return (NULL);
>> H> +	}
>>
>> All three should just disappear as interfaces :)
>
> What? Why?
Because thay aren't really interfaces. All they need is BPF.
There is a cleaner approach described here: 
http://lists.freebsd.org/pipermail/freebsd-net/2012-December/034031.html

>
> --
> Rui Paulo
>
>