svn commit: r241373 - head/lib/libc/stdlib

[Eitan Adler]

On 9 October 2012 12:33, Andrey Chernov <ache at freebsd.org> wrote:
> Do you check assembler output for _both_ cases?

Yes.

> In my testing clang and gcc xor's 'junk' properly in case it have
> 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'.

volatile is still undefined: see 5.1.2.2.3 and 6.7.2.4 of ISO9899

> IMHO this change should be backed out for srandomdev() and adding
> 'volatile' for sranddev() instead.

http://blog.eitanadler.com/2012/10/reduced-entropy-in-rand-and-random.html

for additional details and actual assembler output.


-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams