svn commit: r235723 - in head: contrib/byacc
tools/regression/usr.bin/yacc usr.bin/yacc usr.bin/yacc/test
Dag-Erling Smørgrav
des at des.no
Tue May 22 10:22:56 UTC 2012
Baptiste Daroussin <bapt at FreeBSD.org> writes:
> Log:
> Import byacc from invisible island, it brings us lots of compatibilities with
> bison, keeping full compatibility with our previous yacc
> implementation.
This commit broke the build, in large part because Baptiste tested with
Clang instead of GCC, and GCC generates a warning when compiling the
generated code. Baptiste has a patch ready to commit, currently
undergoing review by myself and other interested parties.
I chose not to ask Baptiste to revert the commit, because it is a
complex commit that copies some files from a vendor branch into contrib
and removes others from the usr.bin/yacc, and I wasn't sure that
reverting it wouldn't cause trouble with merge tracking.
Lessons learned:
1) always test a *stock* build before committing:
% cd /usr/src && env __MAKE_CONF=/dev/null make buildworld
2) the contrib part and the usr.bin part should probably have been
committed separately.
DES
--
Dag-Erling Smørgrav - des at des.no
More information about the svn-src-head
mailing list