svn commit: r238172 - head/sys/dev/agp

[Marcel Moolenaar]

On Jul 6, 2012, at 11:12 AM, Konstantin Belousov wrote:

>>  agp_i810.c:
>>  While arguably the use of Maxmem can be considered correct, replace its use
>>  with realmem anyway. agp_i810.c is specific to amd64, i386 & pc98, which
>>  have a dense physical memory layout. Avoiding Maxmem here is done with an
>>  eye on copy-n-paste behaviour in general and to avoid confusion caused by
>>  using realmem in agp.c and Maxmem in agp_i810.c.
> The agp_i810.c use is to prevent attachment when largest physical address
> of populated memory exceeds GPU limits established by PTE format and
> chipset errata. Editing Maxmem to be spelled as realmem seems to change
> nothing right now, but I do argue that this is wrong, and commit message
> makes future archeology quite confusing.

The commit log states it all, including how one can arguably call the change
wrong. What exactly is confusing?

-- 
Marcel Moolenaar
marcel at xcllnt.net