svn commit: r230252 - head/sys/fs/tmpfs
Jaakko Heinonen
jh at FreeBSD.org
Tue Jan 24 15:15:28 UTC 2012
On 2012-01-23, Mikolaj Golub wrote:
> JH> Yes, the patch below does that. I suspect that flipping the MNT_RDONLY
> JH> flag may be enough for tmpfs but I am not sure.
>
> I see two issues with this patch:
>
> 1) 'mount -u -o rw /mnt' does not upgrade to rw, although it returns success.
Argh, this is another nmount(2) bug. The update mount code automatically
sets the MNT_RDONLY flag but doesn't unset it. However the string option
always gets updated causing string options and flags to get out of sync.
Flags covered by MNT_UPDATEMASK are unset automatically.
> I think when remounting ro you should call vflush(), something like below:
Right.
Thanks for looking at the patch!
--
Jaakko
More information about the svn-src-head
mailing list