svn commit: r229714 - head/sys/netinet

[Navdeep Parhar]

On Fri, Jan 06, 2012 at 11:05:15PM +0400, Gleb Smirnoff wrote:
>   Navdeep,
> 
> On Fri, Jan 06, 2012 at 06:29:41PM +0000, Navdeep Parhar wrote:
> N> Author: np
> N> Date: Fri Jan  6 18:29:40 2012
> N> New Revision: 229714
> N> URL: http://svn.freebsd.org/changeset/base/229714
> N> 
> N> Log:
> N>   Always release the inp lock before returning from tcp_detach.
> 				 ^ after ?

I don't see anything wrong in the message.  The lock is released within
tcp_detach (before it returns), and not after.


Navdeep


> 
> N> Modified:
> N>   head/sys/netinet/tcp_usrreq.c
> N> 
> N> Modified: head/sys/netinet/tcp_usrreq.c
> N> ==============================================================================
> N> --- head/sys/netinet/tcp_usrreq.c	Fri Jan  6 18:18:25 2012	(r229713)
> N> +++ head/sys/netinet/tcp_usrreq.c	Fri Jan  6 18:29:40 2012	(r229714)
> N> @@ -204,8 +204,10 @@ tcp_detach(struct socket *so, struct inp
> N>  			tcp_discardcb(tp);
> N>  			in_pcbdetach(inp);
> N>  			in_pcbfree(inp);
> N> -		} else
> N> +		} else {
> N>  			in_pcbdetach(inp);
> N> +			INP_WUNLOCK(inp);
> N> +		}
> N>  	}
> N>  }
> N>  
> 
> -- 
> Totus tuus, Glebius.