svn commit: r232181 - in head/sys: kern sys

[Mikolaj Golub]

On Wed, 29 Feb 2012 12:03:00 +0000 Robert N. M. Watson wrote:

 RNMW> I think the monitoring aspect of the patch is fine.

 RNMW> The bit I was worried about was external umask changes. This can cause
 RNMW> race conditions for applications that manage their umask -- for
 RNMW> example, bsdtar, if I recall correctly. It's one thing to use a
 RNMW> debugger to force an application to change its umask -- the developer
 RNMW> needs to know they are changing application behaviour. But exposing a
 RNMW> feature that can lead to correct applications but incorrect results is
 RNMW> a risky thing to do, hence my objection.

 RNMW> I think given the other objections, it would be wise to remove write
 RNMW> access to process umasks, but retain read access for procstat (which is
 RNMW> quite useful, I agree).

I still don't see why having a sysctl RW is worse than asking users to run
something like in the attach when they need to change umask for another
process, but ok, if people don't like RW I will remove it.

-- 
Mikolaj Golub