svn commit: r239074 - head/usr.sbin/ctladm
Steve Kargl
sgk at troutmask.apl.washington.edu
Sun Aug 5 17:53:58 UTC 2012
On Sun, Aug 05, 2012 at 05:23:47PM +0000, Dimitry Andric wrote:
> Author: dim
> Date: Sun Aug 5 17:23:47 2012
> New Revision: 239074
> URL: http://svn.freebsd.org/changeset/base/239074
>
> Log:
> In usr.sbin/ctladm/ctladm.c, function cctl_error_inject(), initialize
> the 'retval' variable to zero, to avoid returning garbage in several
> cases.
>
> This fixes the following clang 3.2 warnings:
>
> usr.sbin/ctladm/ctladm.c:1234:6: error: variable 'retval' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> if (ioctl(fd, CTL_ERROR_INJECT, &err_desc) == -1) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dimitry can you wrap these long error messages to something
shorter than 80 characters. The commit messages are otherwise
pain to read.
--
Steve
More information about the svn-src-head
mailing list