svn commit: r216954 - head/sys/kern

Julian Elischer julian at freebsd.org
Thu Jan 6 09:00:02 UTC 2011


On 1/5/11 11:39 AM, Bruce Evans wrote:
> On Wed, 5 Jan 2011, John Baldwin wrote:
>
>> On Wednesday, January 05, 2011 11:17:20 am Jaakko Heinonen wrote:
>>> On 2011-01-04, John Baldwin wrote:
>>>> Err, no, the point of NOTREACHED is to serve as documentation for 
>>>> lint(1), but
>>>> that has subsequently been obsoleted by __dead2.
>>>
>>> style(9) is out of date then?
>>
>> According to bde@'s most recent e-mails, yes.
>
> It's obviously out of date, since its only example of using 
> NOTREACHED is after a usage() call, and this usage is missing a 
> __dead2.  Of course it
> doesn't use NOTREACHED after its 3 exit() calls or its 2 err() calls or
> its 1 errx() call, so its "should" requirement for using NOTREACHED is
> mostly not satisfied by itself.

However I feel that teh notreached comment is as much for the reader 
as the compiler/lint.

Removing it makes the code  harder to understand for the feeble minded 
such as myself.
>
> Bruce
>



More information about the svn-src-head mailing list