svn commit: r210578 - head/usr.bin/grep
Gabor Kovesdan
gabor at FreeBSD.org
Thu Jul 29 21:25:37 UTC 2010
Em 2010.07.29. 22:20, M. Warner Losh escreveu:
> In message:<20100729122034.GA28899 at stack.nl>
> Jilles Tjoelker<jilles at stack.nl> writes:
> : On Thu, Jul 29, 2010 at 12:11:14AM +0000, Gabor Kovesdan wrote:
> :> Author: gabor
> :> Date: Thu Jul 29 00:11:14 2010
> :> New Revision: 210578
> :> URL: http://svn.freebsd.org/changeset/base/210578
> :
> :> Log:
> :> - Some improvements on the exiting code, like replacing memcpy with
> :> strlcpy/strcpy
> :
> : Hmm, I don't think this is an improvement :(
>
> I agree in this case. The changes don't actually improve the safety
> of the code, but may make the code slower due to the need to recompute
> the length...
>
Thanks to both of you for the comments. I'll talk to my mentor and
revert those changes.
Gabor
More information about the svn-src-head
mailing list