svn commit: r210479 - head/usr.bin/grep

[Dag-Erling Smørgrav]

Gabor Kovesdan <gabor at FreeBSD.org> writes:
> I did run regression testing, the test suite that GNU grep has.

Does that test suite include a test for the bug you fixed?  If not,
running it before committing this particular patch was close to useless.

By definition, a regression test is designed to trigger a specific bug
so the developer(s) can make sure it is not reintroduced at some later
point once it's been fixed.  Standard procedure is for the developer to
write a regression test *before* fixing the bug, and verifying that the
test fails when run against the unpatched code and succeeds when run
against the patched code.

DES
-- 
Dag-Erling Smørgrav - des at des.no