svn commit: r199465 - head/lib/librt

[M. Warner Losh]

In message: <200911180135.nAI1ZaIe051549 at svn.freebsd.org>
            David Xu <davidxu at freebsd.org> writes:
: Author: davidxu
: Date: Wed Nov 18 01:35:36 2009
: New Revision: 199465
: URL: http://svn.freebsd.org/changeset/base/199465
: 
: Log:
:   Fix compiler warnings.
: 
: Modified:
:   head/lib/librt/sigev_thread.c
: 
: Modified: head/lib/librt/sigev_thread.c
: ==============================================================================
: --- head/lib/librt/sigev_thread.c	Wed Nov 18 01:13:15 2009	(r199464)
: +++ head/lib/librt/sigev_thread.c	Wed Nov 18 01:35:36 2009	(r199465)
: @@ -439,9 +439,9 @@ worker_routine(void *arg)
:  {
:  	struct sigev_node *sn = arg;
:  
: -	_pthread_cleanup_push(worker_cleanup, sn);
: +	pthread_cleanup_push(worker_cleanup, sn);
:  	sn->sn_dispatch(sn);
: -	_pthread_cleanup_pop(1);
: +	pthread_cleanup_pop(1);
:  
:  	return (0);
:  }

This change causes libthr to be needed now for librt.  Before this
wasn't the case, so ntp break on mips now (I haven't looked at other
arcs yet).  _pthread_cleanup_pop is exported from libc, while
pthread_cleanup_pop causes __pthread_cleanup_pop_imp to be referenced,
which is defined in libthr.

I guess that's a long way of saying "gee, this seems wrong to me,
please explain what you are fixing better or revert this change,
thanks" :)

Warner