svn commit: r190098 - in head/sys/sparc64: fhc sparc64
Christoph Mallon
christoph.mallon at gmx.de
Sat Mar 28 12:17:40 PDT 2009
Julian Elischer schrieb:
> M. Warner Losh wrote:
>> In message: <49C5F88C.3070600 at freebsd.org>
>> Andriy Gapon <avg at freebsd.org> writes:
>> : E.g. you can have a simple 3 line block where you need a local variable
>> : but that block is located 50 lines from start of an enclosing function.
>> : Very convenient when you need to quickly glance the variable's type
>> (not).
>>
>> No you don't. There's absolutely nothing wrong with putting them at
>> the top. In fact, it is simpler, really, than having to go hunting
>> for dozens of different declarations. As someone who has spent a lot
>> of time looking at code, the time wasted looking for these damn-fool
>> things really adds up.
>
> and in a complicated function, if you have them all over the place you
> have no idea as to what the potential stack usage of the function is..
> This matters in the kernel.
The declared local variables are neither a lower *nor* an upper bound
for stack usage.
More information about the svn-src-head
mailing list