svn commit: r195181 - in head/sys: nfsclient nfsserver

[Steve Kargl]

On Tue, Jun 30, 2009 at 05:17:48AM +0000, bz0fbd at zabbadoz.net wrote:
> On Tue, 30 Jun 2009, John Baldwin wrote:
> 
> >Author: jhb
> >Date: Tue Jun 30 03:18:51 2009
> >New Revision: 195181
> >URL: http://svn.freebsd.org/changeset/base/195181
> >
> >Log:
> > Fix build with NFS_LEGACYRPC enabled after the socket upcall locking
> > changes.
> 
> is this really a good idea, considering that NFS_LEGACYRPC is on the
> "removal list" for 8.0?

Yes.

1) This option definitely worked on April 18th.
2) The option was broken by a commit that was never tested!  If anything
   this should remind committers to either get a code review or test
   their patch.

> 
> Will it go or will it stay?  I thought it was already (partly) gone?
> 

Well, as of June 1, this option was technically gone due to a ill-formed
patch.

-- 
Steve