svn commit: r195862 - head/sys/netinet/ipfw

[Julian Elischer]

Tor Egge wrote:
> This commit causes my laptop to hang during boot.
> 
> ipfw and ipfw_nat are both compiled into the kernel:
> 
> options         IPFIREWALL
> options         IPFIREWALL_VERBOSE
> options         IPFIREWALL_VERBOSE_LIMIT=100
> options         IPFIREWALL_FORWARD
> options         IPFIREWALL_NAT
> options         IPDIVERT
> 
> The kernel hangs during
> 
>     IPFW_WLOCK(&V_layer3_chain);
> 
> at the start of ipfw_nat_init.  The lock is not yet initialized at this time
> (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY), since the commit moved the
> initialization of the lock from
> (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256) (cf. ipfw_modevent() calling
> ipfw_init()) to (SI_SUB_KTHREAD_INIT, SI_ORDER_ANY) (cf. vnet_ipfw_init()).
> 
> - Tor Egge

hmmm odd, runs here...

I'll check it right now
I wonder whats diff...... ooooooh my last tests were with ipfw as a 
module.....


ok I wonder where the "right" place to add it is.. probably keep it
at  SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256.

an you check if that fixes it?  possibly moving the 256 to 255?