svn commit: r184780 - head/usr.sbin/cron/crontab

[Matteo Riondato]

On Sun, Nov 9, 2008 at 3:48 AM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Sun, Nov 09, 2008 at 07:34:11AM +0000, Matteo Riondato wrote:
>>
>> +void
>> +static remove_tmp(int sig)
>> +{
>> +     if (tmp_path) {
>> +             unlink(tmp_path);
>> +     }
>> +     exit(ERROR_EXIT);
>> +}
>
> This looks weird: `static' should be on same line as `void' as `static
> void' (so ^remove_tmp would match).  It will also always exit with
> ERROR_EXIT, which does not look right, does it?

Sure. I reverted the file back to the previous revision. I got other
comments which suggest I should work on a better version of the patch.
I'll do it later today...
Sorry for the noise.
Best regards
-- 
Matteo Riondato
FreeBSD Committer (http://www.freebsd.org)
G.U.F.I. Staff Member (http://www.gufi.org)
FreeSBIE Developer (http://www.freesbie.org)