svn commit: r185544 - head/sys/modules/ae

Bjoern A. Zeeb bz at FreeBSD.org
Tue Dec 2 09:15:09 PST 2008


On Tue, 2 Dec 2008, Sam Leffler wrote:

Hi,

> Bjoern A. Zeeb wrote:
>> On Tue, 2 Dec 2008, Paul Saab wrote:
>> 
>>> Author: ps
>>> Date: Tue Dec  2 04:45:33 2008
>>> New Revision: 185544
>>> URL: http://svn.freebsd.org/changeset/base/185544
>>> 
>>> Log:
>>>  Fix world by including opt_route.h
>> 
>> Where did world fail for you?
>> 
>> I assume what failed was a single direct module build? Per discussion
>> on current@ we are working on this but it's a long list of files with
>> awkward dependencies to go through.
>> 
>> If that was the only problem, the manual module build, please let me
>> know so I can back this out again as soon as the vimage header files
>> are untangled.
> Note I added explicit opt_route.h to all the ath-related modules because I 
> hit problems too.  I must've missed the discussion on current at .

No problem and thanks for the note.

I have removed them all and then readded the ones still (really)
needed.  The universe that is currently building doesn't have them
in ath*/Makefiles and ae/Makefile anymore.

Did a make depend in sys/modules/ and after the initial untangling we
are down from ~390 to 14 modules still inlcuding vnet.h and thus depending
on opt_route.h

A veriosn of the patch is here:
http://people.freebsd.org/~bz/20081202-v-h-06.diff

There is more cleanup to follow afterwards.

I also found quite a few other spots going through more >100 files...
but that's initally unrelated and in my general "INET cleanup"
pigeonhole.

/bz

-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.


More information about the svn-src-head mailing list