svn commit: r365735 - head/sys/dev/iicbus

[Warner Losh]

Author: imp
Date: Mon Sep 14 23:30:04 2020
New Revision: 365735
URL: https://svnweb.freebsd.org/changeset/base/365735

Log:
  Don't do the busy dance in icee_open/close
  
  We don't need to do the busy dance for this driver. It's handled by
  destroy_dev() entirely. Since all we did was busy/unbusy in
  open/close, just delete them. We therefore don't need to track closes
  either.
  
  Reviewed by: ian@
  Differential Revision: https://reviews.freebsd.org/D26431

Modified:
  head/sys/dev/iicbus/icee.c

Modified: head/sys/dev/iicbus/icee.c
==============================================================================
--- head/sys/dev/iicbus/icee.c	Mon Sep 14 23:27:51 2020	(r365734)
+++ head/sys/dev/iicbus/icee.c	Mon Sep 14 23:30:04 2020	(r365735)
@@ -113,17 +113,12 @@ static struct ofw_compat_data compat_data[] = {
 #define CDEV2SOFTC(dev)		((dev)->si_drv1)
 
 /* cdev routines */
-static d_open_t icee_open;
-static d_close_t icee_close;
 static d_read_t icee_read;
 static d_write_t icee_write;
 
 static struct cdevsw icee_cdevsw =
 {
 	.d_version = D_VERSION,
-	.d_flags = D_TRACKCLOSE,
-	.d_open = icee_open,
-	.d_close = icee_close,
 	.d_read = icee_read,
 	.d_write = icee_write
 };
@@ -227,28 +222,6 @@ icee_detach(device_t dev)
 	struct icee_softc *sc = device_get_softc(dev);
 
 	destroy_dev(sc->cdev);
-	return (0);
-}
-
-static int 
-icee_open(struct cdev *dev, int oflags, int devtype, struct thread *td)
-{
-	struct icee_softc *sc;
-
-	sc = CDEV2SOFTC(dev);
-	if (device_get_state(sc->dev) < DS_BUSY)
-		device_busy(sc->dev);
-
-	return (0);
-}
-
-static int
-icee_close(struct cdev *dev, int fflag, int devtype, struct thread *td)
-{
-	struct icee_softc *sc;
-
-	sc = CDEV2SOFTC(dev);
-	device_unbusy(sc->dev);
 	return (0);
 }