svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph...

[Andrew Gallatin]

On 2020-09-02 22:42, Alexey Dokuchaev wrote:

>> I want to understand which rules have to be followed (and why).
> 
> In general, FreeBSD code we write should follow style(9); it specifically
> mentions "do not add whitespace at the end of a line" and "... followed by
> one blank line" but doesn't go as far as explicitly forbidding multiple
> consecutive newlines.  To me it's pretty obvious, and while others might
> have different sens esthe'tique, usually it is lack thereof (no offense)
> or mere ignorance.
> 
> ./danfe
> 
> P.S.  Old-school tools like indent(1) or `uncrustify' were never widely
> popular, I guess, because they did not possess enough knowledge of the
> language to always produce correct results.  Perhaps new era tools, like
> clang-format, could bring this to a whole new level.
> 

I do the upstream sync between the Netflix tree and
FreeBSD-current about every 3 weeks (unless glebius beats
me to the punch and does it first :).  I anticipate that
this blank line sweep will cause lots of conflicts for us.
I understand this is progress, and I don't object, and I'm
not asking for a revert, but please understand that cleanups
like this do have hidden costs.  I expect that other commercial
entities who contribute to FreeBSD will have the same issue,
and I also anticipate it will cause problems with MFCs

Rather than doing more sweeps like this, is it possible to
come up with a clang-format rule that's 95% of style(9), do
just one more sweep of the tree to apply that rule, add that
rule as a pre-commit hook, and be done forever with style(9)
related changes?

Thanks,
Drew