svn commit: r366381 - head/sys/modules/pwm

[Cy Schubert]

In message <50246694-58eb-0a68-7c9f-309ae2777e08 at FreeBSD.org>, Jung-uk Kim writ
es:
>
> On 20. 10. 3., Cy Schubert wrote:
> > In message <CAGudoHECuyebLK5197TBV4MXAHOhTWE0B5yNBMvWRPxy5zN7fQ at mail.gmail.
> c
> > om>
> > , Mateusz Guzik writes:
> >> On 10/2/20, Emmanuel Vadot <manu at freebsd.org> wrote:
> >>> Author: manu
> >>> Date: Fri Oct  2 19:56:54 2020
> >>> New Revision: 366381
> >>> URL: https://svnweb.freebsd.org/changeset/base/366381
> >>>
> >>> Log:
> >>>   pwm_backlight: Restrict module to armv7 and aarch64
> >>>
> >>>   Both powerpc64 and riscv uses fdt but don't use EXT_RESOURCES.
> >>>
> >>>   Reported by:	jenkins
> >>>
> >>> Modified:
> >>>   head/sys/modules/pwm/Makefile
> >>>
> >>> Modified: head/sys/modules/pwm/Makefile
> >>> =========================================================================
> ==
> >> ===
> >>> --- head/sys/modules/pwm/Makefile	Fri Oct  2 19:16:06 2020	(r36638
> >> 0)
> >>> +++ head/sys/modules/pwm/Makefile	Fri Oct  2 19:56:54 2020	(r36638
> >> 1)
> >>> @@ -6,8 +6,10 @@ SUBDIR = \
> >>>  	pwmbus \
> >>>  	pwmc \
> >>>
> >>> +.if ${MACHINE_ARCH} == "armv7" || ${MACHINE_ARCH} == "aarch64"
> >>>  .if !empty(OPT_FDT)
> >>>  SUBDIR += pwm_backlight
> >>> +.endif
> >>>  .endif
> >>>
> >>>  .include <bsd.subdir.mk>
> >>
> >> I don't know which commits are to blame, but the following is broken
> >> in tinderbox:
> >> arm GENERIC kernel failed, check _.arm.GENERIC for details
> >> arm GENERIC-NODEBUG kernel failed, check _.arm.GENERIC-NODEBUG for details
> >> arm TEGRA124 kernel failed, check _.arm.TEGRA124 for details
> >> arm ARMADA38X kernel failed, check _.arm.ARMADA38X for details
> >> arm VYBRID kernel failed, check _.arm.VYBRID for details
> >> arm GENERIC-MMCCAM kernel failed, check _.arm.GENERIC-MMCCAM for details
> >> arm LINT kernel failed, check _.arm.LINT for details
> >> arm IMX53 kernel failed, check _.arm.IMX53 for details
> >> arm IMX6 kernel failed, check _.arm.IMX6 for details
> >> arm EFIKA_MX kernel failed, check _.arm.EFIKA_MX for details
> >> arm ZEDBOARD kernel failed, check _.arm.ZEDBOARD for details
> > 
> > And on amd64 my laptop is useless now.
> > 
> > Oct  2 18:23:58 slippy kernel: link_elf_obj: symbol 
> > acpi_video_get_backlight_type undefined
> > Oct  2 18:23:58 slippy kernel: Warning: memory type debugfsint leaked 
> > memory on destroy (2 allocations, 80 bytes leaked).
> > Oct  2 18:23:59 slippy kernel: linker_load_file: /boot/modules/i915kms.ko -
>  
> > unsupported file type
> > 
> > And this is also after updating drm-current-kmod.
>
> Create files directory, add the attached patch there, and try again.
>
> Jung-uk Kim
>
>
> --- drivers/gpu/drm/i915/display/intel_opregion.c.orig	2020-10-02 18:5
> 0:12 UTC
> +++ drivers/gpu/drm/i915/display/intel_opregion.c
> @@ -25,6 +25,8 @@
>   *
>   */
>  
> +#include <sys/param.h>
> +
>  #include <linux/acpi.h>
>  #include <linux/dmi.h>
>  #include <linux/firmware.h>
> @@ -450,10 +452,12 @@ static u32 asle_set_backlight(struct drm_i915_private 
>  
>  	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
>  
> +#if __FreeBSD_version < 1300118
>  	if (acpi_video_get_backlight_type() == acpi_backlight_native) {
>  		DRM_DEBUG_KMS("opregion backlight request ignored\n");
>  		return 0;
>  	}
> +#endif
>  
>  	if (!(bclp & ASLE_BCLP_VALID))
>  		return ASLC_BACKLIGHT_FAILED;
>

This won't work. The machine is already at 1300118.
I'll try a #if 0 instead.

(I restored a zfs snapshot of /usr/src and /usr/obj.)


Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy at nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.