svn commit: r359385 - head/usr.bin/kyua

[Brooks Davis]

On Sat, Mar 28, 2020 at 07:42:04PM -0700, Enji Cooper wrote:
> 
> > On Mar 28, 2020, at 7:37 PM, Enji Cooper <yaneurabeya at gmail.com> wrote:
> > 
> >> 
> >> On Mar 27, 2020, at 8:22 PM, Brooks Davis <brooks at freebsd.org <mailto:brooks at freebsd.org>> wrote:
> >> 
> >> On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote:
> >>> Author: ngie
> >>> Date: Sat Mar 28 01:08:20 2020
> >>> New Revision: 359385
> >>> URL: https://svnweb.freebsd.org/changeset/base/359385 <https://svnweb.freebsd.org/changeset/base/359385>
> >>> 
> >>> Log:
> >>>  Check in the generated copies of the manpages
> >>> 
> >>>  These manpages were meant to be templated once per `configure` run.
> >>> 
> >>>  Given that we're not bound by as many constants, e.g., `--prefix` isn't
> >>>  generally changing for kyua in the base system, having to generate the
> >>>  manpages each build seems slightly less than optimal.
> >>> 
> >>>  In the event that one's build environment doesn't define `$SH`, the build
> >>>  will also fail until this change is introduced.
> >>> 
> >>>  Instead of jumping through hoops dealing with shells or permissions, let's
> >>>  just cut to the chase and check the generated copies into the sourcebase
> >>>  under usr.bin/kyua .
> >> 
> >> This was the wrong fix.  Committing generated manpaged was
> >> 100% the wrong solution and will make extra work in the
> >> future.  The correct fix is almost certainly the one attached to
> >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086 <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086>.  If someone
> >> doesn't beat me to it I will revert you wrong and broken commit along
> >> with the followups and commit the correct one (this certainly won't be
> >> until at least tomorrow).
> > 
> > I???ll revert my changes.
> 
> 	Done in r359417.

Thank you!

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20200329/7325350e/attachment.sig>