svn commit: r359207 - stable/11/usr.sbin/extattr
Alan Somers
asomers at FreeBSD.org
Sun Mar 22 02:56:04 UTC 2020
Author: asomers
Date: Sun Mar 22 02:56:03 2020
New Revision: 359207
URL: https://svnweb.freebsd.org/changeset/base/359207
Log:
MFC r356809:
setextattr: Increase stdin buffer size to 4096
Extended attribute values can potentially be quite large. One test for ZFS
is supposed to set a 200MB xattr. However, the buffer size for reading
values from stdin with setextattr -i is so small that the test times out
waiting for tiny chunks of data to be buffered and appended to an sbuf.
Increasing the buffer size should help alleviate some of the burden of
reallocating larger sbufs when writing large extended attributes.
Submitted by: Ryan Moeller <ryan at freqlabs.com>
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D23211
Modified:
stable/11/usr.sbin/extattr/rmextattr.c
Directory Properties:
stable/11/ (props changed)
Modified: stable/11/usr.sbin/extattr/rmextattr.c
==============================================================================
--- stable/11/usr.sbin/extattr/rmextattr.c Sun Mar 22 02:54:59 2020 (r359206)
+++ stable/11/usr.sbin/extattr/rmextattr.c Sun Mar 22 02:56:03 2020 (r359207)
@@ -104,7 +104,7 @@ mkbuf(char **buf, int *oldlen, int newlen)
int
main(int argc, char *argv[])
{
-#define STDIN_BUF_SZ 1024
+#define STDIN_BUF_SZ 4096
char stdin_data[STDIN_BUF_SZ];
char *p;
More information about the svn-src-all
mailing list