svn commit: r362126 - head/sys/vm

[John Baldwin]

On 6/17/20 5:48 PM, Conrad Meyer wrote:
> On Wed, Jun 17, 2020 at 10:50 AM John Baldwin <jhb at freebsd.org> wrote:
>>
>> On 6/12/20 3:33 PM, Conrad Meyer wrote:
>>> On Fri, Jun 12, 2020 at 2:53 PM Eric van Gyzen <vangyzen at freebsd.org> wrote:
>>>>   Honor db_pager_quit in some vm_object ddb commands
>>>>
>>>>   These can be rather verbose.
>>>
>>> We also have this (?)hack in OneFS, which eliminates the need for
>>> every debug function to check the db_pager globals:
>>>
>>> https://people.freebsd.org/~cem/db_pager.patch
>>>
>>> I'm not sure how objectionable it is.
>>
>> I don't think this addresses that.  I think this patch makes printf turn
>> into db_printf when a function is invoked from DDB which is orthogonal.
>> db_printf() itself doesn't check the pager.
> 
> db_printf checks the pager, via db_putc.

It doesn't break out of the loops for you though (e.g. via setjmp or the
like).  Commands still have to check db_pager_quit directly if they wish
to abort early to honor a user entering 'q' at the pager prompt.

-- 
John Baldwin