Please include benchmarks in commit messages (was Re: svn commit: r363450 - in head: share/man/man3 sys/sys)

[Colin Percival]

[Picking this as an example of a general trend...]

On 2020-07-23 10:16, Doug Moore wrote:
>   [...]
>   Testing has shown that for the cases where red-black trees do worst,
>   wavl trees better balance leads to faster lookups, so that if lookups
>   outnumber insertions by a nontrivial amount, lookup time saved exceeds
>   the extra cost of balancing.

I'd like to request that commits like this include some benchmarks.  In the
review of these particular changes I see several microbenchmarks for a variety
of use cases; it could be helpful to future code spelunkers if these were
summarized in the commit message (e.g. "lookup-heavy microbenchmarks saw a
X% speedup while write-heavy microbenchmarks saw a Y% slowdown").  It would
also be nice to see a macrobenchmark (e.g. buildworld), even (and perhaps
*especially*) if the result is "no difference was observed".

Again, this is a general request -- this is just the latest in a long series
of commits I've seen by many people which have sounded like they could have
performance impacts but have not included any quantitative results.

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid