svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

[Gleb Smirnoff]

  Hi,

On Wed, Jan 15, 2020 at 06:05:20AM +0000, Gleb Smirnoff wrote:
T> Log:
T>   Introduce NET_EPOCH_CALL() macro and use it everywhere where we free
T>   data based on the network epoch.   The macro reverses the argument
T>   order of epoch_call(9) - first function, then its argument. NFC

I really want to reverse the argument order of epoch_call() as well.
The current order is really backwards:

     void
     epoch_call(epoch_t epoch, epoch_context_t ctx,
         void (*callback)(epoch_context_t));

Suggested declaration is:

     void
     epoch_call(epoch_t epoch, epoch_context_t ctx,
        void (*callback)(epoch_context_t));

This will be a very easy change, since today function is
used just in few places.

Before branching stable/12 we intentionally put this
note in epoch.9 manual page:

NOTES
     The epoch kernel programming interface is under development and is
     subject to change.

Any objections?

-- 
Gleb Smirnoff