svn commit: r358074 - head/sys/arm/allwinner/clkng

Dimitry Andric dim at FreeBSD.org
Tue Feb 18 17:55:25 UTC 2020


Author: dim
Date: Tue Feb 18 17:55:24 2020
New Revision: 358074
URL: https://svnweb.freebsd.org/changeset/base/358074

Log:
  Fix the following -Werror warning from clang 10.0.0:
  
  sys/arm/allwinner/clkng/aw_clk_mipi.c:144:6: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
                                          m++;
                                          ^
  sys/arm/allwinner/clkng/aw_clk_mipi.c:142:5: note: previous statement is here
                                  if (best == *fout)
                                  ^
  
  Move the increment operations into the for loop headers instead.
  
  Discussed with:	manu
  MFC after:	3 days

Modified:
  head/sys/arm/allwinner/clkng/aw_clk_mipi.c

Modified: head/sys/arm/allwinner/clkng/aw_clk_mipi.c
==============================================================================
--- head/sys/arm/allwinner/clkng/aw_clk_mipi.c	Tue Feb 18 16:39:57 2020	(r358073)
+++ head/sys/arm/allwinner/clkng/aw_clk_mipi.c	Tue Feb 18 17:55:24 2020	(r358074)
@@ -129,9 +129,9 @@ aw_clk_mipi_find_best(struct aw_clk_mipi_sc *sc, uint6
 	*factor_k = 0;
 	*factor_m = 0;
 
-	for (n = aw_clk_factor_get_min(&sc->n); n <= aw_clk_factor_get_max(&sc->n); ) {
-		for (k = aw_clk_factor_get_min(&sc->k); k <= aw_clk_factor_get_max(&sc->k); ) {
-			for (m = aw_clk_factor_get_min(&sc->m); m <= aw_clk_factor_get_max(&sc->m); ) {
+	for (n = aw_clk_factor_get_min(&sc->n); n <= aw_clk_factor_get_max(&sc->n); n++) {
+		for (k = aw_clk_factor_get_min(&sc->k); k <= aw_clk_factor_get_max(&sc->k); k++) {
+			for (m = aw_clk_factor_get_min(&sc->m); m <= aw_clk_factor_get_max(&sc->m); m++) {
 				cur = (fparent * n * k) / m;
 				if ((*fout - cur) < (*fout - best)) {
 					best = cur;
@@ -141,11 +141,8 @@ aw_clk_mipi_find_best(struct aw_clk_mipi_sc *sc, uint6
 				}
 				if (best == *fout)
 					return (best);
-					m++;
 			}
-				k++;
 		}
-			n++;
 	}
 
 	return best;


More information about the svn-src-all mailing list