svn commit: r364746 - in head: . cddl/compat/opensolaris/include cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd...

[Alexey Dokuchaev]

On Tue, Aug 25, 2020 at 02:21:27AM +0000, Matt Macy wrote:
> New Revision: 364746
> URL: https://svnweb.freebsd.org/changeset/base/364746
> 
> Log:
>   Merge OpenZFS support in to HEAD.
>   
>   The primary benefit is maintaining a completely shared
>   code base with the community allowing FreeBSD to receive
>   new features sooner and with less effort.

This commit raises several questions.  To start, I see a lot of things
checked in under `sys/contrib/openzfs' which do not belong to the kernel
(e.g. userland programs, libraries, manpages, bash completions, test
suite, etc/sudoers.d) or FreeBSD at all (init.d, initramfs, systemd).
Why those bits were not cleaned up, or at least kept on the vendor
branch only?

>   Improvements include:
>     project quotas, encrypted datasets,
>     allocation classes, vectorized raidz,
>     vectorized checksums, various command line
>     improvements, zstd compression.

And what about regressions?  Would illumos (opensolaris) ZFS be also
offered, maybe from ports, for those of us who prefer stable and highly
reliable implementation?

> Added: head/cddl/lib/libicp/Makefile
> ...
> +        core/kcf_prov_lib.c \
> +        core/kcf_callprov.c \
> +        core/kcf_mech_tabs.c \
> +        core/kcf_prov_tabs.c \
> +        $(ASM_SOURCES_C)
> +
> +
> +
> +
> +
> +
> +SRCS= $(ASM_SOURCES_AS) $(KERNEL_C)

There are many excessive whitespace bugs, this is the most prominent.
How did they pass the review?

./danfe