svn commit: r360276 - in head/sys: amd64/amd64 arm64/arm64 i386/i386 powerpc/powerpc
Mark Johnston
markj at FreeBSD.org
Fri Apr 24 18:47:44 UTC 2020
Author: markj
Date: Fri Apr 24 18:47:42 2020
New Revision: 360276
URL: https://svnweb.freebsd.org/changeset/base/360276
Log:
Remove an obsolete TODO comment from several minidump implementations.
The comment referenced a non-existent function, and these minidump
implementations already buffer discontiguous physical data pages by
mapping them into a single VA range that gets passed to the dump device,
so there is no real advantage in batching calls to blk_write().
The RISC-V and MIPS minidump implementations still write a page at a
time and so would benefit from some form of batching.
MFC after: 2 weeks
Sponsored by: Juniper Networks, Klara Inc.
Modified:
head/sys/amd64/amd64/minidump_machdep.c
head/sys/arm64/arm64/minidump_machdep.c
head/sys/i386/i386/minidump_machdep_base.c
head/sys/powerpc/powerpc/minidump_machdep.c
Modified: head/sys/amd64/amd64/minidump_machdep.c
==============================================================================
--- head/sys/amd64/amd64/minidump_machdep.c Fri Apr 24 16:40:42 2020 (r360275)
+++ head/sys/amd64/amd64/minidump_machdep.c Fri Apr 24 18:47:42 2020 (r360276)
@@ -409,7 +409,6 @@ minidumpsys(struct dumperinfo *di)
}
/* Dump memory chunks */
- /* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
while (bits) {
Modified: head/sys/arm64/arm64/minidump_machdep.c
==============================================================================
--- head/sys/arm64/arm64/minidump_machdep.c Fri Apr 24 16:40:42 2020 (r360275)
+++ head/sys/arm64/arm64/minidump_machdep.c Fri Apr 24 18:47:42 2020 (r360276)
@@ -374,7 +374,6 @@ minidumpsys(struct dumperinfo *di)
}
/* Dump memory chunks */
- /* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
while (bits) {
Modified: head/sys/i386/i386/minidump_machdep_base.c
==============================================================================
--- head/sys/i386/i386/minidump_machdep_base.c Fri Apr 24 16:40:42 2020 (r360275)
+++ head/sys/i386/i386/minidump_machdep_base.c Fri Apr 24 18:47:42 2020 (r360276)
@@ -321,7 +321,6 @@ minidumpsys(struct dumperinfo *di)
}
/* Dump memory chunks */
- /* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
while (bits) {
Modified: head/sys/powerpc/powerpc/minidump_machdep.c
==============================================================================
--- head/sys/powerpc/powerpc/minidump_machdep.c Fri Apr 24 16:40:42 2020 (r360275)
+++ head/sys/powerpc/powerpc/minidump_machdep.c Fri Apr 24 18:47:42 2020 (r360276)
@@ -381,7 +381,6 @@ retry:
dump_total("pmap", pmapsize);
/* Dump memory chunks */
- /* XXX cluster it up and use blk_dump() */
for (i = 0; i < vm_page_dump_size / sizeof(*vm_page_dump); i++) {
bits = vm_page_dump[i];
/* TODO optimize with bit manipulation instructions */
More information about the svn-src-all
mailing list