svn commit: r346160 - head/usr.bin/mandoc

[Li-Wen Hsu]

On Sat, Apr 13, 2019 at 3:53 AM Enji Cooper <yaneurabeya at gmail.com> wrote:
>
>
> > On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu <lwhsu at FreeBSD.org> wrote:
> >
> > Author: lwhsu
> > Date: Fri Apr 12 18:35:14 2019
> > New Revision: 346160
> > URL: https://svnweb.freebsd.org/changeset/base/346160
> >
> > Log:
> >  Suppress old gcc warning about null format string
> >
> >  This is workaround to make head build on gcc using architectures
> >
> >  Sponsored by:        The FreeBSD Foundation
> >  MFC-with:    r346149
> >
> > Modified:
> >  head/usr.bin/mandoc/Makefile
> >
> > Modified: head/usr.bin/mandoc/Makefile
> > ==============================================================================
> > --- head/usr.bin/mandoc/Makefile      Fri Apr 12 18:13:57 2019        (r346159)
> > +++ head/usr.bin/mandoc/Makefile      Fri Apr 12 18:35:14 2019        (r346160)
> > @@ -97,6 +97,8 @@ SRCS=               ${LIB_SRCS} \
> > WARNS?=       3
> > CFLAGS+= -DHAVE_CONFIG_H \
> >        -I${SRCTOP}/lib/libopenbsd/
> > +# This can be removed after swtiching to newer gcc
> > +CFLAGS.gcc+= -Wno-format
> > LIBADD=       openbsd z
> >
> > .include <bsd.prog.mk>
>
>         Couldn’t this be fixed upstream and pulled back in, instead of ignoring the warning?

That's possible, but I don't know how much of the possibility that
upstream is willing to fix a warning that only occurs in old versions
of gcc, and it looks a false positive to me.  I am here to put a
band-aid first.

Best,
Li-Wen