svn commit: r345707 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us...

[Rodney W. Grimes]

> Author: ngie
> Date: Fri Mar 29 18:43:46 2019
> New Revision: 345707
> URL: https://svnweb.freebsd.org/changeset/base/345707
> 
> Log:
>   Revert r345706: the third time will be the charm
>   
>   When a review is closed via Phabricator it updates the patch attached to the
>   review. I downloaded the raw patch from Phabricator, applied it, and repeated
>   my mistake from r345704 by accident mixing content from D19732 and D19738.

Which, arguable is a feature or mis feature depending on the point
of view.  I do not like it when I go to look at someone elses
committed code siting a review, as I want to actually see what
it was that was committed.  You can find the pre-commit diff,
but it takes a bit of probling.  The upside is you can get
both diffs from the same place and diff the diffs :-)

>   For my own personal sanity, I will try not to mix reviews like this in the
>   future.

:-)  Been there, almost did that too.
Pre commit last minute svn diff saved me.


>   MFC after:	1 month
>   MFC with:	r345706
>   Approved by:	emaste (mentor, implicit)
...

-- 
Rod Grimes                                                 rgrimes at freebsd.org