svn commit: r354116 - in head: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/lib/libzfs/common sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/sys/fs

[Alan Somers]

Ack, my bad.  Fix coming...

On Sat, Oct 26, 2019 at 12:37 PM Dan Mack <mack at macktronics.com> wrote:

>
> This appears to have broken my buildworld unless I did something wrong on
> my end: Last Changed Rev: 354116
>
>
> snip ...
>
> ===> lib/ofed/libibumad (all)
> --- all_subdir_lib/libbe ---
> /usr/src/lib/libbe/be_info.c:260:67: error: too few arguments to function
> call, expected 5, have 3
>          return (zfs_iter_snapshots_sorted(hdl, prop_list_builder_cb,
> data));
>                  ~~~~~~~~~~~~~~~~~~~~~~~~~                                ^
> /usr/src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h:575:1: note:
> 'zfs_iter_snapshots_sorted' declared here
> extern int zfs_iter_snapshots_sorted(zfs_handle_t *, zfs_iter_f, void *,
> ^
> 1 error generated.
> *** [be_info.o] Error code 1
>
> On Sat, 26 Oct 2019, Alan Somers wrote:
>
> > Author: asomers
> > Date: Sat Oct 26 17:11:02 2019
> > New Revision: 354116
> > URL: https://svnweb.freebsd.org/changeset/base/354116
> >
> > Log:
> >  MFZoL:  Avoid retrieving unused snapshot props
> >
> >  This patch modifies the zfs_ioc_snapshot_list_next() ioctl to enable it
> >  to take input parameters that alter the way looping through the list of
> >  snapshots is performed. The idea here is to restrict functions that
> >  throw away some of the snapshots returned by the ioctl to a range of
> >  snapshots that these functions actually use. This improves efficiency
> >  and execution speed for some rollback and send operations.
> >
> >  Reviewed-by: Tom Caputi <tcaputi at datto.com>
> >  Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov>
> >  Reviewed by: Matt Ahrens <mahrens at delphix.com>
> >  Signed-off-by: Alek Pinchuk <apinchuk at datto.com>
> >  Closes #8077
> >  zfsonlinux/zfs at 4c0883fb4af0d5565459099b98fcf90ecbfa1ca1
> >
> >  MFC after:   2 weeks
> >
> > Modified:
> >  head/cddl/contrib/opensolaris/cmd/zfs/zfs_iter.c
> >  head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c
> >  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h
> >  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c
> >  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_iter.c
> >  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_sendrecv.c
> >  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
> >  head/sys/cddl/contrib/opensolaris/uts/common/sys/fs/zfs.h
>
>