svn commit: r354909 - in head: . share/mk

[Ian Lepore]

On Thu, 2019-11-21 at 16:23 +0000, Glen Barber wrote:
> On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote:
> > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote:
> > > Author: brooks
> > > Date: Wed Nov 20 18:36:58 2019
> > > New Revision: 354909
> > > URL: https://svnweb.freebsd.org/changeset/base/354909
> > > 
> > > Log:
> > >   Make the warning for deprecated NO_ variables an error.
> > >   
> > >   Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN,
> > > NO_PROFILE,
> > >   and NO_WARNS as deprecated in 2014 with a warning added for
> > > each one
> > >   found. Turn these into error in preperation for removal of
> > > compatability
> > >   support before FreeBSD 13.
> > >   
> > >   Reviewed by:	imp
> > >   Relnotes:	yes
> > >   Sponsored by:	DARPA, AFRL
> > >   Differential Revision:	https://reviews.freebsd.org/D22448
> > > 
> > > Modified: head/share/mk/bsd.opts.mk
> > > =================================================================
> > > =============
> > > --- head/share/mk/bsd.opts.mk	Wed Nov 20 18:12:01 2019	(
> > > r354908)
> > > +++ head/share/mk/bsd.opts.mk	Wed Nov 20 18:36:58 2019	(
> > > r354909)
> > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS = \
> > >      PROFILE \
> > >      WARNS
> > >  .if defined(NO_${var})
> > > -.warning "NO_${var} is defined, but deprecated. Please use
> > > MK_${var}=no instead."
> > > +.error "NO_${var} is defined, but deprecated. Please use
> > > MK_${var}=no instead."
> > >  MK_${var}:=no
> > >  .endif
> > >  .endfor
> > > 
> > 
> > Had this been exp-run tested?  This breaks at least the
> > net/bsdec2-image-upload port, which does *not* set NO_MAN
> > explicitly in
> > its Makefile.  I suspect at least several other ports are now
> > implicitly
> > broken as result of this change.
> > 
> 
> In fact, on a quick search through ports/*/*/Makefile, I do not see
> NO_MAN defined *anywhere*.  So, this is pulled in from somewhere
> else,
> which now I have a feeling more ports than I initially thought are
> now
> broken.
> 

Your search was too narrow.  Re-do it as "grep -Rw NO_MAN *" from
/usr/ports and you'll get a lot of hits from within files/ dirs.

-- Ian