svn commit: r347087 - stable/12/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat May  4 09:28:11 2019
New Revision: 347087
URL: https://svnweb.freebsd.org/changeset/base/347087

Log:
  MFC r343954:
  Fix a locking bug in the IPPROTO_SCTP level SCTP_EVENT socket option.
  This occurs when call setsockopt() with invalid parameters.
  
  This issue was found by syzkaller.

Modified:
  stable/12/sys/netinet/sctp_usrreq.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet/sctp_usrreq.c
==============================================================================
--- stable/12/sys/netinet/sctp_usrreq.c	Sat May  4 09:25:32 2019	(r347086)
+++ stable/12/sys/netinet/sctp_usrreq.c	Sat May  4 09:28:11 2019	(r347087)
@@ -6115,6 +6115,10 @@ sctp_setopt(struct socket *so, int optname, void *optv
 						SCTP_INP_RUNLOCK(inp);
 					}
 				}
+			} else {
+				if (stcb) {
+					SCTP_TCB_UNLOCK(stcb);
+				}
 			}
 			break;
 		}