svn commit: r345312 - in head: share/man/man9 sys/net sys/sys
John Baldwin
jhb at FreeBSD.org
Wed Mar 20 00:12:18 UTC 2019
On 3/19/19 4:44 PM, Eric Joyner wrote:
> Author: erj
> Date: Tue Mar 19 23:44:26 2019
> New Revision: 345312
> URL: https://svnweb.freebsd.org/changeset/base/345312
>
> Log:
> iflib: mark isc_driver_version as constant
>
> From Jake:
> The iflib core never modifies the isc_driver_version string. Allow
> drivers to safely assign pointers to constant buffers by marking this
> parameter const.
I didn't say it in the review, but FWIW, I probably would have added
SYSCTL_CONST_STRING as its own commit first (so it can be MFC'd standalone,
etc.) with its own message and then committed the iflib change that uses
it second. Just something to consider for the future.
--
John Baldwin
More information about the svn-src-all
mailing list