Re: svn commit: r349349 - in head/stand: efi/include efi/include/Protocol efi/libefi efi/loader libsa

[Dave Cottlehuber]

On Mon, 24 Jun 2019, at 23:19, Rebecca Cran wrote:
> Author: bcran
> Date: Mon Jun 24 23:18:42 2019
> New Revision: 349349
> URL: https://svnweb.freebsd.org/changeset/base/349349
> 
> Log:
>   loader: add HTTP support using UEFI
>   
>   Add support for an HTTP "network filesystem" using the UEFI's HTTP
>   stack.
>   
>   This also supports HTTPS, but TianoCore EDK2 implementations currently
>   crash while fetching loader files.
>   Only IPv4 is supported at the moment. IPv6 support is planned for a
>   follow-up changeset.
>   
>   Note that we include some headers from the TianoCore EDK II project in
>   stand/efi/include/Protocol verbatim, including links to the license instead
>   of including the full text because that's their preferred way of
>   communicating it, despite not being normal FreeBSD project practice.
>   
>   Submitted by:	scottph
>   Reviewed by:	imp, bcran
>   Differential Revision:	https://reviews.freebsd.org/D20643
> 
> Added:
>   head/stand/efi/include/Protocol/Http.h   (contents, props changed)
>   head/stand/efi/include/Protocol/Ip4Config2.h   (contents, props changed)
>   head/stand/efi/include/Protocol/ServiceBinding.h   (contents, props changed)
>   head/stand/efi/libefi/efihttp.c   (contents, props changed)
> Modified:
>   head/stand/efi/include/efidevp.h
>   head/stand/efi/include/efilib.h
>   head/stand/efi/libefi/Makefile
>   head/stand/efi/loader/conf.c
>   head/stand/libsa/stand.h

Many thanks for landing this Rebecca & Scott.

This fails to identify the partition with a bootable zpool on both a laptop (details
in the PR)  and also a server (2 zpools), and instead tries to boot from the EFI
partition where the boot1.efi loader is located (i.e. disk0p1 and not disk0p2).

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238800

A+
Dave