svn commit: r349349 - in head/stand: efi/include efi/include/Protocol efi/libefi efi/loader libsa

[Rodney W. Grimes]

> Author: bcran
> Date: Mon Jun 24 23:18:42 2019
> New Revision: 349349
> URL: https://svnweb.freebsd.org/changeset/base/349349
> 
> Log:
>   loader: add HTTP support using UEFI
>   
>   Add support for an HTTP "network filesystem" using the UEFI's HTTP
>   stack.
>   
>   This also supports HTTPS, but TianoCore EDK2 implementations currently
>   crash while fetching loader files.
>   Only IPv4 is supported at the moment. IPv6 support is planned for a
>   follow-up changeset.
>   
>   Note that we include some headers from the TianoCore EDK II project in
>   stand/efi/include/Protocol verbatim, including links to the license instead
>   of including the full text because that's their preferred way of
>   communicating it, despite not being normal FreeBSD project practice.

Please read the license text below and understand why I might have
a conflict with the above statement when infact the text included
says "which accompanies this distribution."

>   Submitted by:	scottph
>   Reviewed by:	imp, bcran
>   Differential Revision:	https://reviews.freebsd.org/D20643
> 
> Added:
>   head/stand/efi/include/Protocol/Http.h   (contents, props changed)
>   head/stand/efi/include/Protocol/Ip4Config2.h   (contents, props changed)
>   head/stand/efi/include/Protocol/ServiceBinding.h   (contents, props changed)
>   head/stand/efi/libefi/efihttp.c   (contents, props changed)
> Modified:
>   head/stand/efi/include/efidevp.h
>   head/stand/efi/include/efilib.h
>   head/stand/efi/libefi/Makefile
>   head/stand/efi/loader/conf.c
>   head/stand/libsa/stand.h
> 
> Added: head/stand/efi/include/Protocol/Http.h
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/stand/efi/include/Protocol/Http.h	Mon Jun 24 23:18:42 2019	(r349349)
> @@ -0,0 +1,523 @@
> +/* $FreeBSD$ */
> +/** @file
> +  This file defines the EFI HTTP Protocol interface. It is split into
> +  the following two main sections:
> +  HTTP Service Binding Protocol (HTTPSB)
> +  HTTP Protocol (HTTP)
> +
> +  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
> +  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> +  This program and the accompanying materials
> +  are licensed and made available under the terms and conditions of the BSD License
> +  which accompanies this distribution. The full text of the license may be found at

It sys accompanies, that means not a pointer to...

> +  http://opensource.org/licenses/bsd-license.php

Also shouldn't it say 2 clause license, as that is what is pointed at?
Is the above text exactly as it appeared in the file from Tianocore
or has it been edited in any way?

> +
> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

Hum oh my, what has happend to the disclaimer?

> +
> +  @par Revision Reference:
> +  This Protocol is introduced in UEFI Specification 2.5
> +
> +**/
> +
> +#ifndef __EFI_HTTP_PROTOCOL_H__
> +#define __EFI_HTTP_PROTOCOL_H__
...

-- 
Rod Grimes                                                 rgrimes at freebsd.org