svn commit: r348847 - head/sys/sys

[Gleb Smirnoff]

On Mon, Jun 10, 2019 at 11:09:09AM +0200, Tijl Coosemans wrote:
T> > Date: Mon Jun 10 05:28:03 2019
T> > New Revision: 348847
T> > URL: https://svnweb.freebsd.org/changeset/base/348847
T> > 
T> > Log:
T> >   Use C11 anonymous unions.
T> >   
T> >   PR:		215202
T> >   Reported by:	glebius
T> >   MFC after:	2 weeks
T> > 
T> > Modified:
T> >   head/sys/sys/ucred.h
T> > 
T> > Modified: head/sys/sys/ucred.h
T> > ==============================================================================
T> > --- head/sys/sys/ucred.h	Mon Jun 10 05:09:34 2019	(r348846)
T> > +++ head/sys/sys/ucred.h	Mon Jun 10 05:28:03 2019	(r348847)
T> > @@ -89,12 +89,11 @@ struct xucred {
T> >  	gid_t	cr_groups[XU_NGROUPS];	/* groups */
T> >  	union {
T> >  		void	*_cr_unused1;	/* compatibility with old ucred */
T> > -		pid_t	_pid;
T> > -	} _cr;
T> > +		pid_t	cr_pid;
T> > +	};
T> >  };
T> >  #define	XUCRED_VERSION	0
T> >  
T> > -#define	cr_pid _cr._pid
T> >  /* This can be used for both ucred and xucred structures. */
T> >  #define	cr_gid cr_groups[0]
T> 
T> Isn't this a userland header that should work with non-C11 compilers?

It could make sense to keep such low bar for standard headers, but ucred.h
is BSD-specific header and struct xucred is FreeBSD specific.

-- 
Gleb Smirnoff