svn commit: r348504 - in head: lib/clang/libllvm tools/build/mk usr.bin/clang

[Kyle Evans]

Author: kevans
Date: Sun Jun  2 04:04:21 2019
New Revision: 348504
URL: https://svnweb.freebsd.org/changeset/base/348504

Log:
  llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG
  
  ASAN reports become a lot more useful with llvm-symbolizer in $PATH, and the
  build is not much more time-consuming. The added benefit is that the
  resulting reports will actually include symbol information; without, thread
  trace information includes a bunch of addresses that immediately resolve to
  an inline function in
  ^/contrib/compiler-rt/lib/sanitizer_common/sanitizer_common.h and take a
  little more effort to examine.
  
  Reviewed by:	emaste
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D20484

Modified:
  head/lib/clang/libllvm/Makefile
  head/tools/build/mk/OptionalObsoleteFiles.inc
  head/usr.bin/clang/Makefile

Modified: head/lib/clang/libllvm/Makefile
==============================================================================
--- head/lib/clang/libllvm/Makefile	Sun Jun  2 02:38:44 2019	(r348503)
+++ head/lib/clang/libllvm/Makefile	Sun Jun  2 04:04:21 2019	(r348504)
@@ -523,7 +523,7 @@ SRCS_EXT+=	DebugInfo/PDB/PDBSymbolTypeVTableShape.cpp
 SRCS_EXT+=	DebugInfo/PDB/PDBSymbolUnknown.cpp
 SRCS_EXT+=	DebugInfo/PDB/PDBSymbolUsingNamespace.cpp
 SRCS_EXT+=	DebugInfo/PDB/UDTLayout.cpp
-SRCS_EXT+=	DebugInfo/Symbolize/DIPrinter.cpp
+SRCS_MIW+=	DebugInfo/Symbolize/DIPrinter.cpp
 SRCS_MIW+=	DebugInfo/Symbolize/SymbolizableObjectFile.cpp
 SRCS_MIW+=	DebugInfo/Symbolize/Symbolize.cpp
 SRCS_MIN+=	Demangle/ItaniumDemangle.cpp
@@ -779,7 +779,7 @@ SRCS_MIN+=	Support/BinaryStreamWriter.cpp
 SRCS_MIN+=	Support/BlockFrequency.cpp
 SRCS_MIN+=	Support/BranchProbability.cpp
 SRCS_MIN+=	Support/BuryPointer.cpp
-SRCS_EXT+=	Support/COM.cpp
+SRCS_MIW+=	Support/COM.cpp
 SRCS_MIN+=	Support/CachePruning.cpp
 SRCS_MIN+=	Support/Chrono.cpp
 SRCS_MIN+=	Support/CodeGenCoverage.cpp

Modified: head/tools/build/mk/OptionalObsoleteFiles.inc
==============================================================================
--- head/tools/build/mk/OptionalObsoleteFiles.inc	Sun Jun  2 02:38:44 2019	(r348503)
+++ head/tools/build/mk/OptionalObsoleteFiles.inc	Sun Jun  2 04:04:21 2019	(r348504)
@@ -1372,6 +1372,7 @@ OLD_FILES+=usr/bin/clang++
 OLD_FILES+=usr/bin/clang-cpp
 OLD_FILES+=usr/bin/clang-tblgen
 OLD_FILES+=usr/bin/llvm-objdump
+OLD_FILES+=usr/bin/llvm-symbolizer
 OLD_FILES+=usr/bin/llvm-tblgen
 OLD_FILES+=usr/lib/clang/8.0.0/include/sanitizer/allocator_interface.h
 OLD_FILES+=usr/lib/clang/8.0.0/include/sanitizer/asan_interface.h
@@ -1561,7 +1562,6 @@ OLD_FILES+=usr/bin/llvm-objcopy
 OLD_FILES+=usr/bin/llvm-pdbutil
 OLD_FILES+=usr/bin/llvm-ranlib
 OLD_FILES+=usr/bin/llvm-rtdyld
-OLD_FILES+=usr/bin/llvm-symbolizer
 OLD_FILES+=usr/bin/llvm-xray
 OLD_FILES+=usr/bin/opt
 OLD_FILES+=usr/share/man/man1/bugpoint.1.gz

Modified: head/usr.bin/clang/Makefile
==============================================================================
--- head/usr.bin/clang/Makefile	Sun Jun  2 02:38:44 2019	(r348503)
+++ head/usr.bin/clang/Makefile	Sun Jun  2 04:04:21 2019	(r348504)
@@ -8,6 +8,7 @@ SUBDIR+=	llvm-tblgen
 
 .if !defined(TOOLS_PREFIX)
 SUBDIR+=	llvm-objdump
+SUBDIR+=	llvm-symbolizer
 
 .if ${MK_CLANG_EXTRAS} != "no"
 SUBDIR+=	bugpoint
@@ -33,7 +34,6 @@ SUBDIR+=	llvm-nm
 SUBDIR+=	llvm-objcopy
 SUBDIR+=	llvm-pdbutil
 SUBDIR+=	llvm-rtdyld
-SUBDIR+=	llvm-symbolizer
 SUBDIR+=	llvm-xray
 SUBDIR+=	opt
 .endif