svn commit: r343416 - head/bin/sh

[Edward Tomasz Napierała]

On 0125T1813, Alexey Dokuchaev wrote:
> On Fri, Jan 25, 2019 at 06:02:58AM +0000, Edward Napierala wrote:
> > The aliases are gone, let's continue on the remaining bits below.
> 
> They are not gone, they were commented out; also, bogus double linefeeds
> are not gone.

Yeah, I've matched the existing comment style in that file.

> But most importantly, this whole file is useless and IMHO
> should just be removed.  /bin/sh is not supposed to be one's interactive
> shell.

Of course it is an interactive shell.  We've been using it as the
default interactive shell for non-root accounts since... ages.

> > It is alien, because it's different from their experience
> > from other systems they are used to.
> 
> This argument does not really hold because /bin/sh is not... see above.
> 
> > It doesn't affect existing installs.  It doesn't affect people
> > who run the default root shell (tcsh), nor folks who use shells
> 
> AFAICT default root shell is /bin/csh, not tcsh. ;-)  But that also

Our csh _is_ tcsh.

> means that /usr/src/bin/sh/dot.shrc doesn't have to exist: those who
> change the root shell should either pick another interactive shell,
> or if they want /bin/sh be ready to deal with sanitary environment.

See above.

> > And for folks who do have their own tree with their preferred
> > /root/.shrc to "make distribution" from, it should actually make
> > their diff to upstream smaller.
> 
> I don't like extra files, esp. configuration files that look like they
> are for interactive shell while our /bin/sh is in fact not.  This is
> confusing, and FreeBSD is not supposed to be confusing.

Again, sh(1) is an interactive shell.

> > It is a syntax problem:
> > 
> > trasz at v2:~ % while :; do date; sleep 1; done
> > while: Expression Syntax.
> > do: Command not found.
> > done: Command not found.
> 
> Are you trying to use sh(1) loop in (t)csh?  Why?  And what does it have
> to do with the /usr/src/bin/sh/dot.shrc issue?

I'm trying to explain the basic problem with our default shell:
it doesn't work, because it can't handle what people call the
shell syntax.