svn commit: r344294 - head/lib/libc/posix1e
Sean Eric Fagan
sef at FreeBSD.org
Tue Feb 19 19:15:16 UTC 2019
Author: sef
Date: Tue Feb 19 19:15:15 2019
New Revision: 344294
URL: https://svnweb.freebsd.org/changeset/base/344294
Log:
Remove some redundant code in _posix1e_acl_strip_np
This was discovered through examination -- acl_copy_entry() copies the
tag type and permset fields.
Reviewed by: trasz, pfg
Sponsored by: iXsystems Inc.
Differential Revision: https://reviews.freebsd.org/D19240
Modified:
head/lib/libc/posix1e/acl_strip.c
Modified: head/lib/libc/posix1e/acl_strip.c
==============================================================================
--- head/lib/libc/posix1e/acl_strip.c Tue Feb 19 19:13:48 2019 (r344293)
+++ head/lib/libc/posix1e/acl_strip.c Tue Feb 19 19:15:15 2019 (r344294)
@@ -70,7 +70,6 @@ _posix1e_acl_strip_np(const acl_t aclp, int recalculat
{
acl_t acl_new, acl_old;
acl_entry_t entry, entry_new;
- acl_permset_t perm;
acl_tag_t tag;
int entry_id, have_mask_entry;
@@ -104,15 +103,7 @@ _posix1e_acl_strip_np(const acl_t aclp, int recalculat
case ACL_USER_OBJ:
case ACL_GROUP_OBJ:
case ACL_OTHER:
- if (acl_get_tag_type(entry, &tag) == -1)
- goto fail;
- if (acl_get_permset(entry, &perm) == -1)
- goto fail;
if (acl_create_entry(&acl_new, &entry_new) == -1)
- goto fail;
- if (acl_set_tag_type(entry_new, tag) == -1)
- goto fail;
- if (acl_set_permset(entry_new, perm) == -1)
goto fail;
if (acl_copy_entry(entry_new, entry) == -1)
goto fail;
More information about the svn-src-all
mailing list